Request to self-merge gh-21802

The PR MAINT: special: Remove dependence of xsf::numpy on scipy's sf_error by steppi · Pull Request #21802 · scipy/scipy · GitHub shuffles around some code related to error handling in scipy/special/xsf/numpy.h to make it so the xsf headers no longer depend on any code in scipy/special outside of xsf. This is the last structural barrier in the way of beginning the migration of the scipy/special/xsf codebase to the separate xsf repo described in RFC: Plan for establishment of xsf library for special function scalar kernels · Issue #1 · scipy/xsf · GitHub.

The SciPy Core Developer Guide states

In case review doesn’t happen quickly enough and it is important that the PR is merged quickly, the submitter of the PR should send a message to the forum saying they intend to merge that PR without review at time X for reason Y unless someone reviews it before then.

I would like to self-merge this PR by this coming Thursday if a maintainer is unable to review by then. Currently there is an approval from @izaid, who is an expert in C++ and numerical algorithms, and also the original author of the code I’ve modified. If someone is willing to take a look and push the button before Thursday I would appreciate it. Getting this done is needed to begin working on the xsf migration, which I hope to finish before we branch for 1.15.

1 Like

I’ve merged MAINT: special: remove dependence of `xsf::numpy` on `sf_error` by steppi · Pull Request #21802 · scipy/scipy · GitHub

1 Like